[GH-429] Dungeon Settlement Levels #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncontinanza
requested changes
May 13, 2024
Co-authored-by: Nicolas Continanza <[email protected]>
agustinesco
reviewed
May 14, 2024
|
|
||
| Returns the updated user if the operation was successful. | ||
| """ | ||
| def level_up_dungeon_settlement(user_id, level_up_costs) do |
There was a problem hiding this comment.
Isn't this the same as level_up_kaline_tree? just changing the increment_settlement_levelright?
agustinesco
reviewed
May 14, 2024
| get_user(user_id) | ||
| end | ||
|
|
||
| defp increment_settlement_level(user_id) do |
agustinesco
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds DungeonSettlementLevels to Users
Closes https://github.com/lambdaclass/champions_of_mirra/issues/429
Summary of changes
How to test it?
You can create a user and check that his dungeon_settlement_level is instantiated at level 1.
If you give your user 50 "Blueprints" (using
GameBackend.Users.Currencies.add_currency_by_name!/3), you will be able to level up the dungeon settlement of your user withChampions.Users.level_up_dungeon_settlement/1. If you get your user again (Champions.Users.get_user_by_username/1) you will be able to see that his dungeon_settlement_level has increased, and his "Gold" and "Blueprints" currencies decreased!Since this implements protobuf messages, this PR also adds SocketTester messages! You can also try those :P